[misc] Fix invalid whitespace character causing inability to parse moment.js #3853
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…browser during parsing in Chrome.
jesstelford
approved these changes
Mar 21, 2017
There was a problem hiding this comment.
This fixes the same issue we were having, which was breaking all our builds (as moment is a dep of a dep, we can't roll back... The dark side of semver ranges). Thanks for tracking it down!
cc @ichernev
Nicktho
approved these changes
Mar 21, 2017
gpoole
approved these changes
Mar 21, 2017
shmendo
changed the title
|
Thanks guys! After looking at some open issues I may try and help out in that respect as time allows. Appreciate the warm welcome :) |
|
I'll cut a release in around 5hrs |
|
YTMND @ichernev |
|
Merged in 863f861 |
ichernev
changed the title
ichernev
added a commit
that referenced
this pull request
Mar 21, 2017
[misc] Fix invalid whitespace character causing inability to parse moment.js
|
Enjoy 2.18.1 |
Closed
|
Hi guys, Has this fix been released yet? We're getting loads of issues about this in our project graph3d. Edit: Never mind. I just figured out if we do a release ourselves, the issue will be fixed. |
mojoaxel
added a commit
to almende/vis
that referenced
this pull request
Mar 28, 2017
see moment/moment#3853 fixes #2912
bradh
pushed a commit
to almende/vis
that referenced
this pull request
Mar 28, 2017
mojoaxel
added a commit
to visjs/vis-charts
that referenced
this pull request
Jul 12, 2019
see moment/moment#3853 fixes #2912
mojoaxel
added a commit
to visjs/vis-charts
that referenced
this pull request
Jul 28, 2019
see moment/moment#3853 fixes #2912
mojoaxel
added a commit
to visjs/vis-charts
that referenced
this pull request
Jul 28, 2019
see moment/moment#3853 fixes #2912
mojoaxel
added a commit
to visjs/vis-charts
that referenced
this pull request
Jul 28, 2019
see moment/moment#3853 fixes #2912
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see the attached screenshots from Chrome 56.0.2924.87.
It appears there is an invalid whitespace character in the source code in
src/lib/locale/set.js. I removed that character and added a standard space which appears to have fixed the problem. I still ran the tests and confirmed all passed.This can be reproduced by adding the following index.html file in the repo at the root of the project and loading it in chrome.
I should note that I put the whitespace replacement into the file referenced above, then ran
grunt releaseand confirmed that it did indeed fix the issue.